-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Az.Compute - MSP AddProxyAgentExtension parameter #28634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
@ookoka please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Commenter does not have sufficient privileges for PR 28634 in repo Azure/azure-powershell |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
f311d48
to
a2d6b22
Compare
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
25d8194
to
39e97a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds the AddProxyAgentExtension
parameter to Azure PowerShell compute cmdlets as requested in the linked issue. The parameter enables implicit installation of the ProxyAgent Extension, which is currently applicable only for Linux OS.
Key changes include:
- Added
AddProxyAgentExtension
parameter toNew-AzVM
andNew-AzVmss
as a switch parameter - Added
AddProxyAgentExtension
parameter toSet-AzVMProxyAgentSetting
andSet-AzVmssProxyAgentSetting
as a boolean parameter - Updated underlying strategy and model classes to support the new parameter
Reviewed Changes
Copilot reviewed 18 out of 92 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
help/*.md files | Updated documentation to include the new AddProxyAgentExtension parameter |
NewAzureVMCommand.cs | Added AddProxyAgentExtension switch parameter to New-AzVM cmdlet |
SetAzVMProxyAgentSetting.cs | Added AddProxyAgentExtension boolean parameter to Set-AzVMProxyAgentSetting cmdlet |
VirtualMachineStrategy.cs | Updated strategy to handle the new parameter in VM creation |
VirtualMachineScaleSetStrategy.cs | Updated strategy to handle the new parameter in VMSS creation |
VirtualMachineScaleSetCreateOrUpdateMethod.cs | Added AddProxyAgentExtension switch parameter to New-AzVmss cmdlet |
Model classes | Added AddProxyAgentExtension property to PowerShell model objects |
Test files | Added test scenarios for the new functionality |
ChangeLog.md | Documented the new parameter additions |
ComputeRP.json | Updated to API version 2025-04-01 with various enhancements |
src/Compute/Compute/VirtualMachine/Config/SetAzVMProxyAgentSetting.cs
Outdated
Show resolved
Hide resolved
src/Compute/Compute/VirtualMachine/Config/SetAzVMProxyAgentSetting.cs
Outdated
Show resolved
Hide resolved
src/Compute/Compute/Strategies/ComputeRp/VirtualMachineScaleSetStrategy.cs
Show resolved
Hide resolved
src/Compute/Compute/Strategies/ComputeRp/VirtualMachineScaleSetStrategy.cs
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
@isra-fel Do you mind running this again? I think something happened with the commit so Bot refused to run |
resolved conflicts
…let to allow Param
…VM + VMSS for APAE
…and Set-AzVmssProxyAgentSetting
…e Logic/Strategy Pass Ins
…ds, Matched Logic in VM Strategy with VMSS
e0681a7
to
7b3b084
Compare
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Description
Adding MSP AddProxyAgentExtension parameter to New-AzVM, New-AzVMss, Set-AzVMProxyAgentSetting, Set-AzVMssProxyAgentSetting as requested by this issue
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.